Problem calling std::max
C++WindowsVisual C++BisonC++ Problem Overview
I compiled my bison-generated files in Visual Studio and got these errors:
> ...\position.hh(83): error C2589: '(' : illegal token on right side of '::'
> ...\position.hh(83): error C2059: syntax error : '::'
> ...\position.hh(83): error C2589: '(' : illegal token on right side of '::'
> ...\position.hh(83): error C2059: syntax error : '::'
The corresponding code is:
inline void columns (int count = 1)
{
column = std::max (1u, column + count);
}
I think the problem is with std::max; if I change std::max to equivalent code then there is no problem anymore, but is there a better solution instead of changing the generated code?
Here is the bison file I wrote:
//
// bison.yy
//
%skeleton "lalr1.cc"
%require "2.4.2"
%defines
%define parser_class_name "cmd_parser"
%locations
%debug
%error-verbose
%code requires {
class ParserDriver;
}
%parse-param { ParserDriver& driver }
%lex-param { ParserDriver& driver }
%union {
struct ast *a;
double d;
struct symbol *s;
struct symlist *sl;
int fn;
}
%code {
#include "helper_func.h"
#include "ParserDriver.h"
std::string error_msg = "";
}
%token <d> NUMBER
%token <s> NAME
%token <fn> FUNC
%token EOL
%token IF THEN ELSE WHILE DO LET
%token SYM_TABLE_OVERFLOW
%token UNKNOWN_CHARACTER
%nonassoc <fn> CMP
%right '='
%left '+' '-'
%left '*' '/'
%nonassoc '|' UMINUS
%type <a> exp stmt list explist
%type <sl> symlist
%{
extern int yylex(yy::cmd_parser::semantic_type *yylval,
yy::cmd_parser::location_type* yylloc);
%}
%start calclist
%%
... grammar rules ...
C++ Solutions
Solution 1 - C++
You are probably including windows.h
somewhere, which defines macros named max
and min
.
You can #define NOMINMAX
before including windows.h
to prevent it from defining those macros, or you can prevent macro invocation by using an extra set of parentheses:
column = (std::max)(1u, column + count);
Solution 2 - C++
Define the NOMINMAX symbol at the top of your source, before you include any headers. Visual C++ defines min
and max
as macros somewhere in windows.h, and they interfere with your use of the corresponding standard functions.
#define NOMINMAX